chmod: fix EROFS showing as Permission denied#12200
Open
gabrielhnf wants to merge 5 commits intouutils:mainfrom
Open
chmod: fix EROFS showing as Permission denied#12200gabrielhnf wants to merge 5 commits intouutils:mainfrom
gabrielhnf wants to merge 5 commits intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
Contributor
|
looks good but could you please add a test to make sure we don't regress |
Author
|
Thanks for the suggestion! Also planning a follow-up PR to fix another problem regarding error reporting, should that include tests as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12196
Problem
When running
chmod -Ron a read-only filesystem, uutils was reporting:Instead of the correct:
Cause
safe_chmod_filewas hardcodingChmodError::PermissionDeniedregardless of the actual error returned by the OS, discarding the real error kind.Fix
Map
ErrorKind::ReadOnlyFilesystemto a newChmodError::ReadOnlyFileSystemvariant with the correct message, consistent with GNU coreutils behavior.